search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

Create CODE_OF_CONDUCT.md #101

Closed veganaize closed 2 years ago

veganaize commented 2 years ago

Addresses issue #89

👨‍💻 Changes proposed

Adds a CODE_OF_CODUCT

I was just reading about how to add a code of conduct and it funneled me all the way to this pull request. So I'm just offering it to save someone else the time!

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

ykdojo commented 2 years ago

Thank you. Did you copy it from somewhere else?

veganaize commented 2 years ago

Thank you. Did you copy it from somewhere else?

Yes. It's the default template that Github provides. To my understanding, Github requires the use of a template in order to satisfy the Community Standards checklist.

ykdojo commented 2 years ago

@veganaize I'd rather not have it if it's copied from a template. It'd be better to write it from scratch.

veganaize commented 2 years ago

@veganaize I'd rather not have it if it's copied from a template. It'd be better to write it from scratch.

Okay, no worries @ykdojo !

ykdojo commented 2 years ago

@veganaize cool! If you want, you can commit an empty code of conduct (or maybe just one line) and have people suggest changes.

veganaize commented 2 years ago

@ykdojo Okay, reopening PR with an empty / one-liner code of conduct which can be previewed here.

ykdojo commented 2 years ago

Looks good! I'll wait for another reviewer.

veganaize commented 2 years ago

@subhoghoshX Would you mind reviewing this, at your convenience?

subhoghoshX commented 2 years ago

Thanks for the effort @veganaize. LGTM.

Btw @ykdojo, I don't think there's anything wrong with using the default template provided by github. I checked React, Svelte, NextJS, and Gatsby they all used the template and made modifications to it. I think we can use it and make enough changes to make it our own. As I don't think we have a professional copywriter on our team :laughing:

ykdojo commented 2 years ago

@subhoghoshX the problem with the template is that:

  1. It's too long. I can't really even understand it without spending a lot of time on it.
  2. It's not ours. It's a rule that someone else created.

I think those projects simply copy it just because other projects do, too.

I was comfortable using a template for the license because it's:

  1. A legal document
  2. Short

Neither of which is the code of conduct template.

For not having a copywriter - I can do that until we have another person who can do it, too.

subhoghoshX commented 2 years ago

@subhoghoshX the problem with the template is that:

  1. It's too long. I can't really even understand it without spending a lot of time on it.
  2. It's not ours. It's a rule that someone else created.

I think those projects simply copy it just because other projects do, too.

I was comfortable using a template for the license because it's:

  1. A legal document
  2. Short

Neither of which is the code of conduct template.

For not having a copywriter - I can do that until we have another person who can do it, too.

Understood. Thanks for the explanation.