search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

dx: plausible analytics added #104

Closed rohitdasu closed 1 year ago

rohitdasu commented 2 years ago

🛠️ Fixes Issue #93

Closes #93

👨‍💻 Changes proposed

added flausible(https://plausible.io) analytics

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

ykdojo commented 2 years ago

What are the steps required to set this up?

rohitdasu commented 2 years ago

steps for setting up flausible? @ykdojo

ykdojo commented 2 years ago

yes

rohitdasu commented 2 years ago

done @ykdojo

ykdojo commented 2 years ago

@rohitdasu thank you.

It looks good, but I feel like it's too early to merge right now.

It adds an extra step to setting up the environment, and we don't have any traffic to the site yet.

I think we can merge it once we have more significant traffic coming in?

rohitdasu commented 2 years ago

@rohitdasu thank you.

It looks good, but I feel like it's too early to merge right now.

It adds an extra step to setting up the environment, and we don't have any traffic to the site yet.

I think we can merge it once we have more significant traffic coming in?

sure, should I move this PR to draft to make sure we don't merge it accidentally ?

ykdojo commented 2 years ago

yes making it a draft PR sounds good!