search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

[DX] <Remove the commit message restriction on Husky> #125

Closed ykdojo closed 2 years ago

ykdojo commented 2 years ago

Description

I think we should remove the commit message restriction on Husky.

I get the value of conventional commit messages, but most commits shouldn't show up anyway as long as we squash and merge PRs.

So, as long as the commits on the main branch have the proper format, individual commit messages shouldn't matter so much.

benny123tw commented 2 years ago

This is great! And maybe we could use GitHub Action to run commit lint when PR is triggered?

ykdojo commented 2 years ago

That sounds good!

benny123tw commented 2 years ago

Hi @ykdojo, Can I do this issue? I'll remove commitlint packages and husky hook commit-msg.

I did some tests on GitHub Action I realized that running commit lint on pull requests is the same as we use it locally; it will check all the commits. I think we just need a PR title checker to check the title, so I'll add a workflow to use PR title checker. What do you think?

ykdojo commented 2 years ago

Yes that sounds perfect! Thank you @benny123tw