search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

feat: made the submission box (front-end only for now) #126

Closed ykdojo closed 2 years ago

ykdojo commented 2 years ago

screenshot:

image

closes #59 and #127

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 5:53PM (UTC)
RakeshSangem commented 2 years ago

In order to filter the data/questions in the future, why don't we use tags for questions(arrays, binary trees etc.) ?

__ sema-logo  Summary: :question: I have a question

ykdojo commented 2 years ago

I'd rather keep it simple and not implement tags for now. Maybe later

subhoghoshX commented 2 years ago

Looks good, thank you. I'm not sure about importing all those static fonts. But it's nothing critical I guess, we can optimize later.

I think making the form fields full width and applying some padding on the parent container, might make it look better. Something like below (Open to discuss though). And also a little bit of rounded corner hehe.

image

subhoghoshX commented 2 years ago

Also if I remember correctly, we were supposed to have a separate question and question description field. Looks like you merged it into one.

And also a question category and job title field.

RakeshSangem commented 2 years ago

Also if I remember correctly, we were supposed to have a separate question and question description field. Looks like you merged it into one.

And also a question category and job title field.

yes, title and description should be there!

ykdojo commented 2 years ago

Added position and question fields:

image

For styling, I think we can make it a separate issue/PR? @subhoghoshX

subhoghoshX commented 2 years ago

Sure that'd be better. I think we can merge it then.