[FEATURE] Better user signup/signin flow

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream

MIT License

509 stars 120 forks source link

[FEATURE] Better user signup/signin flow #140

Open ykdojo opened 2 years ago

ykdojo commented 2 years ago

Description

We should handle user signups & signins better.

There are many things to do there:

Better error handling, clearly showing that users have signed in (related to #122), etc.

subhoghoshX commented 2 years ago

I can work on it once PR #133 is merged.

subhoghoshX commented 2 years ago

Alright now that #133 is merged. I'll start working on this one. My plan is to do the following:

[x] Show a Sign In link by default in the Header instead of the name & menu
[x] When the user is signed in, show their name, email, and the menu
[x] Implement Sign Out functionality
[x] Bring back the profile picture thing maybe (open to discussion)
[ ] Show errors in a better way on sign in and sign up pages instead of using alerts.

I'll send a series of PRs.

dattavelivela commented 2 years ago

Hello @subhoghoshX @ykdojo

Can we improve the UX of Sign-up by removing text fields and including "sign up with google", "sign up with Twitter", or "sign up with GitHub", this helps in completing the signup process easier for the users to sign up?

subhoghoshX commented 2 years ago

Can we improve the UX of Sign-up by removing text fields

Could you elaborate on what you mean by removing the text fields?

And I think PR #114 is working on adding social authentications.

dattavelivela commented 2 years ago

Oh, I'm saying instead of giving an option to the user to fill in the username or mail and password. We can have social authentications for sign-in and sign-up.

If a user tries to sign in with an unregistered google account/Apple account/Twitter/Github then

They wouldn't be able to sign in and it displays an error message or notification saying to sign-up

If a user signs in with a registered google account/Twitter/Github/Apple account then

Then we can allow the user to sign in directly.

subhoghoshX commented 2 years ago

Got it. Thanks. As I mentioned social authentication is already in progress. And I believe we should have both options (social & email/password) as some users prefer email/password login.

yaa-chi commented 2 years ago

Hi @subhoghoshX you can check out the user flow here to see if it corresponds with your idea on the sign-up flow: https://www.figma.com/file/DtaNEDhDNz0Wgs4XohV6Pt/Defaang-User-Flow?node-id=0%3A1

subhoghoshX commented 2 years ago

Already checked it. Thanks for the amazing work @yaa-chi.

yaa-chi commented 2 years ago

Already checked it. Thanks for the amazing work @yaa-chi.

You're welcome @subhoghoshX . There's more to come!🥳🎉

Gulshanaggarwal commented 2 years ago

Hey @subhoghoshX , @ykdojo UX experience can be improved when user presses signin or signup button. There should be a loading animation on the button or all over the screen. What do you think?

subhoghoshX commented 2 years ago

Hey @subhoghoshX , @ykdojo UX experience can be improved when user presses signin or signup button. There should be a loading animation on the button or all over the screen. What do you think?

Sounds good. I don't see many sites using it though. Open to discussion.

ykdojo commented 2 years ago

I think the idea is that this process should be fast enough, a loading screen won't make sense - but open to discussion, too

yaa-chi commented 1 year ago

I think the idea is that this process should be fast enough, a loading screen won't make sense - but open to discussion, too

I don't think there's a need to have that either. We can have the loading screen somewhere else though👌🏾

subhoghoshX commented 1 year ago

I don't think there's a need to have that either. We can have the loading screen somewhere else though👌🏾

It's already being implemented in #284 @yaa-chi XD

yaa-chi commented 1 year ago

@subhoghoshX Just saw it, thanksss