csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

feat: show name and menu in header only when user is logged in #146

Closed subhoghoshX closed 2 years ago

subhoghoshX commented 2 years ago

This is the first of the series of PRs that improves the Sign In and Sign Up flow. Please look at #140.

This PR hides the name and menu button when the user is not logged in. Instead, it only shows a link to the Sign In page.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 3:56PM (UTC)
benny123tw commented 2 years ago

maybe use clsx for constructing className strings conditionally?

subhoghoshX commented 2 years ago

maybe use clsx for constructing className strings conditionally?

I'm not sure about adding another dependency for a simple case like this.