search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

[FEATURE] <Improve Header Menu Component> #148

Closed subhoghoshX closed 2 years ago

subhoghoshX commented 2 years ago

Description

This is related to #140.

Right now the Menu component used in the Header doesn't show the user's email on the desktop screen when logged in. It only shows on mobile screens.

I think this component might be a better fit which also shows the email similar to how GitHub does it.

mark-omarov commented 2 years ago

Since nobody is currently assigned, let me take this.

subhoghoshX commented 2 years ago

Haha, I was implicitly assigned to this as it's related to #140. But you can do it if you want.

mark-omarov commented 2 years ago

@subhoghoshX sorry, wasn't aware. I'm not getting much time recently for oss, wanted to do at least something while got a few minutes to spare 😄 The PR is ready, feel free to check it out. If any updates necessary - will be able to update no earlier than by this Friday, sorry 🥲

subhoghoshX commented 2 years ago

No problem :smile: I'm afraid this might cause a merge conflict with my other PR #147. But I guess I'll just resolve it after merging yours.

mark-omarov commented 2 years ago

@subhoghoshX if it's too much hustle, we can do the other way around - once you merge your PR, I'll rebase, fix conflicts, and update my PR. Unfortunately, it might wait until Friday, although, if it's ready by tomorrow, I might be able to get it done tomorrow in the evening (JST time). I'll leave it up to you to decide what's best.

subhoghoshX commented 2 years ago

No worries already merged it. It's nothing critical to wait that long. And the conflict is also pretty easy to resolve.

Thanks for working on it.

mark-omarov commented 2 years ago

My pleasure. Thanks for taking a look and merging! ❤️