csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

[FEATURE] <Show avatar in Header instead of name> #156

Closed subhoghoshX closed 2 years ago

subhoghoshX commented 2 years ago

Description

This is related #140.

I was thinking that we should go back to showing avatar in the Header instead of name. At least show a default avatar for now.

Showing an avatar is the most common pattern. And also when the size of the name varies too much it makes the design look bad.

Would love to know everyone's opinion on this.

mark-omarov commented 2 years ago

I tend to agree, it's also not very intuitive that the name is a menu button. Avatar seems more appropriate to me.

subhoghoshX commented 2 years ago

I tend to agree, it's also not very intuitive that the name is a menu button. Avatar seems more appropriate to me.

Definitely agree with you.

@mark-omarov would you like to take a stab at it? Feel free to go for it if you wanna do it. Here's the code for the Header.

mark-omarov commented 2 years ago

@subhoghoshX sure, weekends ahead, will be able to get at it.

yung-coder commented 2 years ago

@subhoghoshX are you saying for a random profile pic when user sign up ...?

mark-omarov commented 2 years ago

@yung-coder we don't have avatars per se just yet, I'll be adding a default avatar-like icon button, which later on will be enhanced with a custom avatars uploaded through settings.

yung-coder commented 2 years ago

I yeah have got idea with a random or custom avatar when a user sign up ...

@mark-omarov

mark-omarov commented 2 years ago

@yung-coder we've had this discussion somewhere I believe, until we get avatars uploading we won't enable custom avatars. This will require a settings page (or any view alike), supabase migration to enable avatars uploading, model update, and only then implementation on the client.

mark-omarov commented 2 years ago

@subhoghoshX I was playing with the avatar-like button, and when there's an actual image it looks fine, but with a placeholder (icon in our case) it doesn't look as good. How about we make the same format as the notification bell button, and once the user has a profile picture in the model - we can swap the icon to the rounded image instead?

Screen Shot 2022-09-03 at 10 17 58 PM