search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

dx: add custom lint rules #159

Closed benny123tw closed 2 years ago

benny123tw commented 2 years ago

👨‍💻 Changes proposed

📄 Note to reviewers

I suggest we use the generic way for better readability https://github.com/ykdojo/defaang/pull/158#discussion_r962184200

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 6:54AM (UTC)
iShibi commented 2 years ago

string[] -> Array<string> https://github.com/ykdojo/defaang/blob/bd38360602c67ef36b5d16b92ff6c7682a6c74a1/src/components/Header.tsx#L8

Also, while you are at it can you also add this rule: https://typescript-eslint.io/rules/consistent-type-definitions

benny123tw commented 2 years ago

string[] -> Array<string>

https://github.com/ykdojo/defaang/blob/bd38360602c67ef36b5d16b92ff6c7682a6c74a1/src/components/Header.tsx#L8

Also, while you are at it can you also add this rule: https://typescript-eslint.io/rules/consistent-type-definitions

yes, what type do you prefer? interface?

iShibi commented 2 years ago

yes, what type do you prefer? interface?

yeah