search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

Dx: Convert JSX to TSX #186

Closed CerealPlayer closed 2 years ago

CerealPlayer commented 2 years ago

🛠️ Fixes Issue

Closes #181

➕ Changes Introduced

Converted al jsx files to tsx

📄 Note To Reviewers

Types are not too good. As per conversation with @ykdojo over discord, we just want things to move fast and work.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 4:36PM (UTC)
ykdojo commented 2 years ago

@CerealPlayer are you still working on it? Looks like we have conflicts now

CerealPlayer commented 2 years ago

@ykdojo Yeah I saw, however seems like these conflicts need write permissions in order to be merged.

Anyway, I see there are new jsx components so I could make a few more commits

CerealPlayer commented 2 years ago

Just fixed conflicts and converted all jsx elements to tsx elements @ykdojo

Also, I could add changes requested previously by @KyleTryon

subhoghoshX commented 2 years ago

Overall looks good at first glance. Just some nitpicking :smile:

CerealPlayer commented 2 years ago

@subhoghoshX Thank you! And thanks Github for these commit suggestions features 😍

subhoghoshX commented 2 years ago

@subhoghoshX Thank you! And thanks Github for these commit suggestions features :heart_eyes:

Yup, that feature is awesome. Btw I can see some Prettier and TypeScript checks failing, could you look into that? Specifically, it can't seem to find this image @/images/background-call-to-action.jpg.

CerealPlayer commented 2 years ago

Thanks @subhoghoshX . I had to move images to public folder (as far as I know that is the recommended approach NextJS) and point to relative path in Image component as typescript was complaining. Locally it works, but for some reason the GH actions will not allow it.