solved redirecting back from submission page to Homepage

[sanyamjain04]

🛠️ Fixes Issue

Closes #271

➕ Changes Introduced

I have changed the Router method in the signup file from push to replace.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
defaang	✅ Ready (Inspect)	Visit Preview	Oct 8, 2022 at 0:01AM (UTC)

[Olyno]

Hi 👋🏻 Your fix works better than my PR indeed, but you did the change at the wrongplace 😄

[sanyamjain04]

Oh ya sorry, I actually did a silly mistake. Thanks @Olyno

[sanyamjain04]

Now it's solved @ykdojo

[sanyamjain04]

Hey, thanks for you working on it, but I don't think this is what YK addressed in the issue. Just to give you a hint, I don't think it can be done on the client side. You probably want to SSR the page on every request.

Bro this redirect thing should be done on the client side, there is no role for server-side rendering on every request. and this is what Yk has exactly mentioned on the issue. that an unauthenticated user is not able to go back after clicking on submit question button.

[Olyno]

I personally would prefer making the authentication part on the server side. By doing that, we don't see the redirection on the client side, it just loads the page correctly. Also, localStorage lacks of security too, it's one more reason to use on the server side.

That being said, the PR does meet the need, so I have nothing against it.

[Olyno]

I'm confused, why closing the pull request? @sanyamjain04

[sanyamjain04]

I'm confused, why closing the pull request? @sanyamjain04

you just said that the PR doesn't meet the need.

[Olyno]

Nonono i said, it DOES meet the need, that's why i said it was a good PR 😄

[sanyamjain04]

oh sorry, I read it wrong. I think I need some sleep 🥲🥲😂

[Olyno]

It's okay ahah, sorry for making it confusing 😅