search

csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
505 stars 119 forks source link

feat: Better question submission flow #278

Closed Akshay1018 closed 1 year ago

Akshay1018 commented 1 year ago

Added success popup on submitting a new question. Removed extra console.log() from the file submitQuestion

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 4:01PM (UTC)
ykdojo commented 1 year ago

A thumbs up doesn't say much. What are the updates on this PR?

Akshay1018 commented 1 year ago

@ykdojo I have updated the changes you requested for. and committed the code last week.

ykdojo commented 1 year ago

@Akshay1018 thank you so much!

I tested it on the deployed Vercel environment, and I'm getting an error:

image

Mind taking a look?

Akshay1018 commented 1 year ago

@ykdojo Sure! I'm checking.

Akshay1018 commented 1 year ago

@ykdojo If you don't mind could you please check the backend code? When we are getting the confirmation email after signing up and by clicking on confirm "Confirm email", it is taking us to localhost. Please have a look once. Screenshot (18) Screenshot (19)

Akshay1018 commented 1 year ago

@ykdojo The issue is with the backend code because the column name is not matching in questions table. Please have a look at the error. In the payload, we are sending "asked_date" and in the backend, it is expecting "estimated_asked_date". So that's why it is mismatching and throwing errors. I want you to see line no. 62 in the screenshot and in the database please update it to "asked_date". The issue will be resolved. Any further queries or errors please do let me know. Thanks. Screenshot (20) Screenshot (21)

subhoghoshX commented 1 year ago

That shouldn't be an issue as estimated_asked_date is being created here.

Akshay1018 commented 1 year ago

@subhoghoshX If you don't mind could you please check the column name of the questions table in the SQL database? Check if it is estimated_asked_date or asked_date. The same thing happened when I was testing on my local machine.

Akshay1018 commented 1 year ago

@subhoghoshX check for this domain https://defaang-qh3dsuwex-ykdojo.vercel.app/.

subhoghoshX commented 1 year ago

I think I got it. Your branch is not up to date. Please sync your branch. It should be fixed.

Akshay1018 commented 1 year ago

@subhoghoshX exactly! I will pull the code. Thanks.

Akshay1018 commented 1 year ago

@ykdojo @subhoghoshX Its's working with no errors this time. Please check from your end once. Thanks. Screenshot (22) Screenshot (23)