Closed ykdojo closed 2 years ago
Hi @ykdojo , how do you imagine the submission box to look like? Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?
Hi @ykdojo , how do you imagine the submission box to look like? Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?
Currently we have this #24
We should probably have the fields:
Anything else?
What if we have a question category? I think it will be good to know what questions companies are mostly focused on.
Would defaang be focusing on DSA questions, or will it also consist of system design and behavioural questions? @ykdojo
Having a question category sounds good.
Also forgot: the position name.
defaang will do both.
but I bet a lot of the questions will cover DSA
That makes sense.
If no one is working on this. I would love to take it. I haven't used Typescript before, but I believe I can make this work. Would you please assign this to me?
@ykdojo Is the position the job title such as software engineer, or is it the levels such as L3?
The job title. Software Engineer, Site Reliability Engineer, Senior Software Engineer, etc.
Look good! I think the only required fields should be: Company and Question?
Now that I think about it, I'm not sure if we need the date for it since it'll be recorded anyway.
Maybe instead, it should ask "How recently was this question asked? Within the past: 1 month (default choice)" - and let the user pick any other # of months?
That sounds okay. I will make the necessary changes.
LGTM. Make sure to add the "stay anonymous" checkbox as well. And I think the Category can also be a dropdown menu.
@Jonyango I'm not sure where you are on your progress, but I'm thinking of adding my contributions here.
In particular, I'm thinking of:
The required fields:
On stay anonymous, have a tooltip that says something like:
"This question will be associated with your account, but your account will not be shown publicly if this is checked. Later, you'll have an option to un-associate the question from your account completely so it won't even be on record."
Hey @ykdojo. I made the changes suggested on Sunday but haven't made much progress since then(I will get back on this on Friday). Would you like for me to incorporate the new changes you have suggested? Having some design would be helpful here so that I can recreate it faster. I saw that you asked @yaa-chi to help us with the design.
Hi @Jonyango I have actually started with the design. Do check it out here: https://github.com/ykdojo/defaang/issues/82#issuecomment-1219305334
I am currently waiting for everyone to approve of it before We continue to the brand style guide.
@Jonyango yes! thank you.
Mind keeping us updated on your progress here as you work on it?
That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.
Sure that's fine! @ykdojo I'm currently heading towards the logo design. We're done with color palette for both light and dark mode.
After the logo we're gonna go in with the font, and then finally the website layout for all screens.
Sounds good! For the website layout, could you keep Tailwind UI in mind as you go about it?
Sure I will, both light and dark mode. I think it's better now that we have a direct inspiration of how the website will look likeβ‘π
@Jonyango yes! thank you.
Mind keeping us updated on your progress here as you work on it?
That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.
Yes, I will do that.
@Jonyango just FYI, I think I'm going to try implementing this with Tailwind UI - in particular this one called simple stacked.
I'll keep updating this thread as I produce code so we don't duplicate work.
I just got the Application UI package!
Let me know if anyone wants to use any of the components.
I just got the Application UI package!
Let me know if anyone wants to use any of the components.
Really? The premium one?π
I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: https://github.com/ykdojo/defaang/pull/105
I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: #105
YK please what's a draft PRππ
It's just a way to show your code changes, but you're not to have it be reviewed!
oh ok, that's great! Github is really cool I'm learning a lot!
@ykdojo, I am closing the draft PR I raised for this and will try to contribute to the one you have raised.
So I didn't have to close it. I am confused as to why it shows that it was merged.
So I didn't have to close it. I am confused as to why it shows that it was merged.
That's kinda strange and I know GitHub does that sometimes - don't worry about it, though!
Also I just renamed this to only include frontend. Made a new issue for the backend here: https://github.com/ykdojo/defaang/issues/108
@Jonyango any updates? If not, I'm thinking of continuing my work on #105
Moved it to #126 for simplicity (I had some rebasing issues)
Made a separate issue for styling at #127.
@Jonyango, any updates? If not, I'm thinking of continuing my work on #105
Hey. You can continue your work at #105. Life has gotten in the way, and I won't be able to get to it for a while.
Quoting myself from #10:
This should be possible to implement as we have #33 and #34 implemented already.