csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

[FEATURE] <A question submission box> (frontend) #59

Closed ykdojo closed 2 years ago

ykdojo commented 2 years ago

Quoting myself from #10:

The first step is the signup flow as I mentioned at https://github.com/ykdojo/defaang/issues/14, and then after that, maybe a submission box? We can store them privately for now (probably in Supabase or Firebase), and once we have a few, we can make a view for showing those questions.

This should be possible to implement as we have #33 and #34 implemented already.

mark-omarov commented 2 years ago

Hi @ykdojo , how do you imagine the submission box to look like? Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?

Preet-Sojitra commented 2 years ago

Hi @ykdojo , how do you imagine the submission box to look like? Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?

Currently we have this #24

ykdojo commented 2 years ago

We should probably have the fields:

Anything else?

Jonyango commented 2 years ago

What if we have a question category? I think it will be good to know what questions companies are mostly focused on.

Jonyango commented 2 years ago

Would defaang be focusing on DSA questions, or will it also consist of system design and behavioural questions? @ykdojo

ykdojo commented 2 years ago

Having a question category sounds good.

Also forgot: the position name.

ykdojo commented 2 years ago

defaang will do both.

but I bet a lot of the questions will cover DSA

Jonyango commented 2 years ago

That makes sense.

Jonyango commented 2 years ago

If no one is working on this. I would love to take it. I haven't used Typescript before, but I believe I can make this work. Would you please assign this to me?

Jonyango commented 2 years ago

@ykdojo Is the position the job title such as software engineer, or is it the levels such as L3?

ykdojo commented 2 years ago

The job title. Software Engineer, Site Reliability Engineer, Senior Software Engineer, etc.

Jonyango commented 2 years ago

subscription box

ykdojo commented 2 years ago

Look good! I think the only required fields should be: Company and Question?

Now that I think about it, I'm not sure if we need the date for it since it'll be recorded anyway.

Maybe instead, it should ask "How recently was this question asked? Within the past: 1 month (default choice)" - and let the user pick any other # of months?

Jonyango commented 2 years ago

That sounds okay. I will make the necessary changes.

subhoghoshX commented 2 years ago

LGTM. Make sure to add the "stay anonymous" checkbox as well. And I think the Category can also be a dropdown menu.

ykdojo commented 2 years ago

@Jonyango I'm not sure where you are on your progress, but I'm thinking of adding my contributions here.

In particular, I'm thinking of:

ykdojo commented 2 years ago

The required fields:

ykdojo commented 2 years ago

On stay anonymous, have a tooltip that says something like:

"This question will be associated with your account, but your account will not be shown publicly if this is checked. Later, you'll have an option to un-associate the question from your account completely so it won't even be on record."

Jonyango commented 2 years ago

Hey @ykdojo. I made the changes suggested on Sunday but haven't made much progress since then(I will get back on this on Friday). Would you like for me to incorporate the new changes you have suggested? Having some design would be helpful here so that I can recreate it faster. I saw that you asked @yaa-chi to help us with the design.

yaa-chi commented 2 years ago

Hi @Jonyango I have actually started with the design. Do check it out here: https://github.com/ykdojo/defaang/issues/82#issuecomment-1219305334

I am currently waiting for everyone to approve of it before We continue to the brand style guide.

ykdojo commented 2 years ago

@Jonyango yes! thank you.

Mind keeping us updated on your progress here as you work on it?

That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.

yaa-chi commented 2 years ago

Sure that's fine! @ykdojo I'm currently heading towards the logo design. We're done with color palette for both light and dark mode.

After the logo we're gonna go in with the font, and then finally the website layout for all screens.

ykdojo commented 2 years ago

Sounds good! For the website layout, could you keep Tailwind UI in mind as you go about it?

yaa-chi commented 2 years ago

Sure I will, both light and dark mode. I think it's better now that we have a direct inspiration of how the website will look likeβš‘πŸŽ‰

Jonyango commented 2 years ago

@Jonyango yes! thank you.

Mind keeping us updated on your progress here as you work on it?

That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.

Yes, I will do that.

ykdojo commented 2 years ago

@Jonyango just FYI, I think I'm going to try implementing this with Tailwind UI - in particular this one called simple stacked.

I'll keep updating this thread as I produce code so we don't duplicate work.

ykdojo commented 2 years ago

I just got the Application UI package!

Let me know if anyone wants to use any of the components.

yaa-chi commented 2 years ago

I just got the Application UI package!

Let me know if anyone wants to use any of the components.

Really? The premium one?😍

ykdojo commented 2 years ago

This one:

image

https://tailwindui.com/components#pricing

ykdojo commented 2 years ago

I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: https://github.com/ykdojo/defaang/pull/105

yaa-chi commented 2 years ago

I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: #105

YK please what's a draft PRπŸ˜‚πŸ˜‚

ykdojo commented 2 years ago

It's just a way to show your code changes, but you're not to have it be reviewed!

yaa-chi commented 2 years ago

oh ok, that's great! Github is really cool I'm learning a lot!

Jonyango commented 2 years ago

@ykdojo, I am closing the draft PR I raised for this and will try to contribute to the one you have raised.

Jonyango commented 2 years ago

So I didn't have to close it. I am confused as to why it shows that it was merged.

ykdojo commented 2 years ago

So I didn't have to close it. I am confused as to why it shows that it was merged.

That's kinda strange and I know GitHub does that sometimes - don't worry about it, though!

ykdojo commented 2 years ago

Also I just renamed this to only include frontend. Made a new issue for the backend here: https://github.com/ykdojo/defaang/issues/108

ykdojo commented 2 years ago

@Jonyango any updates? If not, I'm thinking of continuing my work on #105

ykdojo commented 2 years ago

Moved it to #126 for simplicity (I had some rebasing issues)

ykdojo commented 2 years ago

Made a separate issue for styling at #127.

Jonyango commented 2 years ago

@Jonyango, any updates? If not, I'm thinking of continuing my work on #105

Hey. You can continue your work at #105. Life has gotten in the way, and I won't be able to get to it for a while.