csdojo-defaang / defaang

A website that will curate recently-asked interview questions from FAANG+. Currently inactive. Check out: https://github.com/ykdojo/OpenStream
MIT License
509 stars 120 forks source link

Update docs #69

Closed subhoghoshX closed 2 years ago

subhoghoshX commented 2 years ago

🛠️ Fixes Issue

Closes #54

👨‍💻 Changes proposed

Update the steps to run the project locally. Also make the it look cleaner.

✔️ Check List (Check all the applicable boxes)

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

subhoghoshX commented 2 years ago

Add a new line before and after a command example, just like the other steps

Prettier formatted it automatically. I think prettier check will fail if I remove it.

iShibi commented 2 years ago

@subhoghoshX I ran npm run format:fix on this and it seems to add a newline before and after correctly. Can you run this cmd and see it fixes the formatting for you?

subhoghoshX commented 2 years ago

@subhoghoshX I ran npm run format:fix on this and it seems to add a newline before and after correctly. Can you run this cmd and see it fixes the formatting for you?

Yeah done. Added it manually. I'm not sure why my prettier acted weirdly back then. Thanks btw.

iShibi commented 2 years ago

You're welcome. You can mark the above reviews as resolved now.

ykdojo commented 2 years ago

feel free to merge it @rohitdasu @subhoghoshX

rohitdasu commented 2 years ago

@subhoghoshX are you done with the changes?

subhoghoshX commented 2 years ago

Yes. You can merge it. Thanks.