cse110-sp23-group3 / 8-ball

0 stars 0 forks source link

How shake animation and audio work? #14

Closed phuanh004 closed 1 year ago

phuanh004 commented 1 year ago

Related to #12, Is it supposed to work on the no answer only, or the yes as well?

Since, the animation looks like only for no, should we split it into a hashtable with, true/ false value?

For example:

{
"It is certain.": true,
"It is decidedly so.": true,
"My sources say no.": false,
}
lemangomeister commented 1 year ago

Are you saying that the animation only works if the answer some variation of no ? I currently have Jiaen's on my local and it works for variations of yes

phuanh004 commented 1 year ago

Are you saying that the animation only works if the answer some variation of no ? I currently have Jiaen's on my local and it works for variations of yes

My bad, I think it is working for both but Idk if ppl want to split them out

nsyousef commented 1 year ago

I think we should play the shaking animation for both yes and no. With physical 8-balls, people generally ask it a question and shake it to get it to tell them the answer.

phuanh004 commented 1 year ago

Yeah, it makes sense.