cse190largecodebases / group-project-bit-converter

group-project-bit-converter created by GitHub Classroom
Other
0 stars 0 forks source link

Implement "git commit" functionality #22

Closed kencasimiro closed 1 year ago

kencasimiro commented 1 year ago

Implemented git commit.

For some reason GitPython's git commit caused tkinter window to crash. Screenshot of error message:

Screenshot 2023-06-07 at 1 57 27 PM

Rather than spending a lot of time debugging the code in tkinter and such, I resorted to do git commit through subprocesses.

Screenshot 2023-06-07 at 2 03 50 PM

Example of git commit - success:

Screenshot 2023-06-07 at 3 12 53 PM

Example of git commit - nothing to commit:

Screenshot 2023-06-07 at 3 13 05 PM
air-wickvu commented 1 year ago

tested on my end and is working. will go ahead and merge.