search

cse210-works-on-my-machine / CSE210-Fall23-Team-3

Repo for Team 3 in CSE210 for the Fall 2023 quarter.
2 stars 0 forks source link

Algorithm changes #32

Closed lakshya-4gp closed 7 months ago

lakshya-4gp commented 7 months ago
  1. Callback added to Fetcher class to directly add the posts to the container, instead of waiting for all the jsons to load
  2. Mastodon posts are shown interleaved instead of all the posts from a certain trending tag first and then next.

Pros:

  1. Response time is much better
  2. Results are shown interleaved so user gets different posts trending in different tags.

Cons: Because of interleaving, possible higher memory usage if the garbage collector can be made to work efficiently to remove the jsons.

Note: Sorry, in case style of coding is different, let me know if those changes are needed.

omprakaash commented 7 months ago

Nice ! Changes look good, but the existing test would now fail though.

omprakaash commented 7 months ago

NIce !