search

cseelhoff / RimThreaded

RimThreaded is a RimWorld mod designed to enable RimWorld to utilize multiple threads.
MIT License
119 stars 21 forks source link

Alien race bug fix #643 & #642 #654

Closed brustmopf closed 2 years ago

brustmopf commented 2 years ago

Hi Hoff,

Finally got used to github.

This is a pull request that fixes some issues with HAR compatibility.

BR Brust

Sernior commented 2 years ago

After doing some digging and talking with Brrainz he pointed me to this article he wrote:

https://harmony.pardeike.net/articles/execution.html#anatomy-of-a-patched-method

Reapplying transpilers is not needed because Harmony does that on its own already.

brustmopf commented 2 years ago

Actually you do need to apply them : While the transpiler does get applied to the original method to generate a modified method, that gets entirely bypassed by the destructive prefix introduced by RT.

What we are transpiling is the prefix in RT... not the original method in RW .

Sernior commented 2 years ago

Yes you are right. This one can be merged.