search

cseelus / monego

The beloved Monaco monospaced font, recreated with a bold and italic variant. Finally.
399 stars 36 forks source link

Some chars in BoldItalic have strange spacing #5

Closed AlynxZhou closed 2 years ago

AlynxZhou commented 2 years ago

Screenshot from 2022-03-07 18-21-18

In this screenshot, the r in warn is BoldItalic, and it has a wrong left spacing, however, the italic r in logger is OK, I am not sure if there are still other wrong chars, but the BoldItalic one always looks strange (compared with Italic version).

cseelus commented 2 years ago

Which version of the font are you using, normal, ligatures or Nerd Font?

AlynxZhou commented 2 years ago

Which version of the font are you using, normal, ligatures or Nerd Font?

Normal version.

cseelus commented 2 years ago

Can you try this version: https://github.com/cseelus/monego/pull/4/commits/502eb55769b57d3472966b8c64bd5cdfc6bd57f0

AlynxZhou commented 2 years ago

Sorry for the late reply.

Screenshot from 2022-03-10 08-43-45

592eb55 looks better, could you fix this for normal version? Because I don't want to use nerd version. Thanks

cseelus commented 2 years ago

Hi @AlynxZhou

Please check out this (normal) version:

Monego.zip

AlynxZhou commented 2 years ago

Hi @AlynxZhou

Please check out this (normal) version:

Monego.zip

Sorry for the late reply, this one's bold-italic works fine, but it seems to break normal italic chars, please see the config's f, i in comment:

New:

Screenshot from 2022-04-18 10-57-46

Old:

Screenshot from 2022-04-18 10-59-03

cseelus commented 2 years ago

Strange, will have to look for a different method with better letter-spacing. Thx for your feedback.

mostafaqanbaryan commented 2 years ago

image

I wanted to add that this problem exists in terminal/vim and it's really bothering me. Monego and Monego-Nerd have no problem and ' is center. But Monego-with-ligatures, which is a great font by the way, this problem occurs and makes me think there is space character before '.

AlynxZhou commented 2 years ago

Strange, will have to look for a different method with better letter-spacing. Thx for your feedback.

Hi, any update on this?

cseelus commented 2 years ago

Not yet. We've been trying to batch fix those spacing issues, but at the moment it looks like the only way to fix it would be to manually adjust each char, which is beyond the scope of this little fork here.

AlynxZhou commented 2 years ago

Could you share how you make bold/italic fonts from the regular one? (maybe scripts or other operations) I really love this custom version, but I am afraid that re-distributing such a copy right font is not OK, but distributing tweak scripts and let user gather font and patch by themselves is always ok.

cseelus commented 2 years ago

@AlynxZhou Check out this PR: https://github.com/cseelus/monego/pull/4