search

cseg-michigan / chez-betty

UM CSEG Food Co-Op Management Software
24 stars 22 forks source link

Updated box and item checks to allow multiple barcodes separated by a… #350

Closed westbl closed 4 years ago

westbl commented 4 years ago

Updated box and item checks to allow multiple barcodes separated by a semicolon as a delimiter. Currently using a single string as storage; "better" methods (allowing multiple barcodes in the database) would require heavy database updates.

This update should ensure that box and item barcode(s) are unique. If implemented, the database should be updated to merge duplicate boxes and items (probably a manual procedure).

westbl commented 4 years ago

@bradjc I updated the code to merge the "update_exists_barcode" and "exists_barcode" functions by giving the "id" variable a default value of "None". I am not sure if it will break the query (I don't know what value Python will put as None in the equality check), but it seemed to work when I tested it locally.

I also updated the code style to match your other comments. Do you like this better?