search

csells / flutter_ai_toolkit

A set of AI chat-related widgets for Flutter
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
33 stars 6 forks source link

bug: blockquote styles not applied to LLM message markdown properly #58

Open csells opened 3 weeks ago

csells commented 3 weeks ago

This is caused by this known issue, open since April of 2021: https://github.com/flutter/flutter/issues/81720

There seems to be an PR to address this issue that wasn't merged: https://github.com/flutter/packages/pull/4396

csells commented 3 weeks ago

@domesticmouse would you be willing to take a look at this? you were a reviewer on the PR. it's blocking proper formatting for the LLM messages of the Flutter AI Toolkit, which uses a MarkdownBody to show rich text output. Thanks!

domesticmouse commented 3 weeks ago

My commitment to this package is to make sure changes have test coverage. I don't actually know the code base. @Gspencergoog may have thoughts on how to fix this.

csells commented 3 weeks ago

Thanks to both of you. The bug in question has a suggested fix.

domesticmouse commented 3 weeks ago

There seems to be an PR to address this issue that wasn't merged: flutter/packages#4396

There is no content in this PR.

The bug in question has a suggested fix.

I've put together https://github.com/flutter/packages/pull/7927 with this fix applied, but the current tests don't pass. Can you debug? And add required tests for your use case?

csells commented 2 weeks ago

Thanks, @domesticmouse. I'll take a look ASAP.