search

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
442 stars 96 forks source link

Refactor package into mini-libraries #103

Closed kevmoo closed 2 years ago

kevmoo commented 2 years ago

I prefer this style – as do many on the Dart team.

Take it or leave it. 🤷

codecov-commenter commented 2 years ago

Codecov Report

Merging #103 (c55d0d3) into master (2a6b0b2) will increase coverage by 0.17%. The diff coverage is 51.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   67.62%   67.80%   +0.17%     
==========================================
  Files           3       11       +8     
  Lines         383      382       -1     
==========================================
  Hits          259      259              
+ Misses        124      123       -1
Impacted Files Coverage Δ
lib/src/custom_transition_page.dart 0.00% <0.00%> (ø)
lib/src/go_route_information_parser.dart 0.00% <0.00%> (ø)
lib/src/inherited_go_router.dart 0.00% <0.00%> (ø)
lib/src/path_strategy_nonweb.dart 0.00% <ø> (ø)
lib/src/go_router.dart 34.09% <34.09%> (ø)
lib/src/logging.dart 50.00% <50.00%> (ø)
lib/src/go_router_delegate.dart 78.38% <54.54%> (ø)
lib/src/go_route.dart 92.30% <92.30%> (ø)
lib/src/go_route_match.dart 93.10% <93.10%> (ø)
lib/src/go_router_state.dart 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a6b0b2...c55d0d3. Read the comment docs.

craiglabenz commented 2 years ago

This gets a +1 from me (not that my vote counts 😆)