search

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
441 stars 97 forks source link

example: more const is good #111

Closed kevmoo closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #111 (a647473) into master (24e6534) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   67.80%   67.80%           
=======================================
  Files          11       11           
  Lines         382      382           
=======================================
  Hits          259      259           
  Misses        123      123

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24e6534...a647473. Read the comment docs.

csells commented 3 years ago

@kevmoo I'm surprised that you found const problems given my strictest possible lint settings. Do I have something misconfigured?

kevmoo commented 3 years ago

@csells – nope! Just noticed that Family and Person could be const – then everything cascaded from there!

csells commented 3 years ago

This causes navigator_integration.dart to fail when adding a new person (as you'd expect).

kevmoo commented 3 years ago

Mutable, static state?

image

csells commented 3 years ago

ha. they're just examples not real apps. : )