search

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
441 stars 97 forks source link

Remove unwanted app flash when deep-linking (Fixes https://github.com/csells/go_router/issues/139) #162

Closed lulupointu closed 2 years ago

lulupointu commented 2 years ago

See https://github.com/csells/go_router/issues/139#issuecomment-968179676 for an extensive description of the issue and the fix.

All the tests are passing.

No breaking changes.

codecov-commenter commented 2 years ago

Codecov Report

Merging #162 (3a63e34) into master (739ea57) will decrease coverage by 0.17%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   67.93%   67.76%   -0.18%     
==========================================
  Files          12       12              
  Lines         393      394       +1     
==========================================
  Hits          267      267              
- Misses        126      127       +1
Impacted Files Coverage Δ
lib/src/go_route_information_parser.dart 0.00% <0.00%> (ø)
lib/src/go_router_delegate.dart 78.05% <0.00%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 739ea57...3a63e34. Read the comment docs.

lulupointu commented 2 years ago

I fixed the complaining lint. Can you try again @csells ?