csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
441 stars 96 forks source link

added_barrier_dissmissable_pagebuilder_to_customtransitionpage #352

Open ismailfarisi opened 2 years ago

ismailfarisi commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

The barrierdissmissable property of customtransitionpage was not working. this bug is fixed also introduced pageBuilder instead of child in customTransitionPage which gives more control for animation

:arrow_heading_down: What is the current behavior?

the dialog is not dissmissing after touching outside screen after making the barrierdissmissable property of customtransitionpage to true

Also the child property of CustomTransitionPage dosent give more control over animation

:new: What is the new behavior (if this is a feature change)?

making the barrierDismmissable property to true makes the dialog dissmissable after pressing outside

more control over animation

:boom: Does this PR introduce a breaking change?

no

:bug: Recommendations for testing

yes

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

csells commented 2 years ago

@ismailfarisi I'm curious why you marked this as not a breaking change. Doesn't everyone that's using CustomTransitionPage today need to move from a child to a pageBuilder?

ismailfarisi commented 2 years ago

actually, I'm new to contributing all the tests were passed in my local test. I believe the failed test might be the public_member_api_docs, so can i put ignore error annotation , Or is there any other way?

chunhtai commented 2 years ago

Since this package has been moved to https://github.com/flutter/packages/tree/main/packages/go_router

Can you create a pull request against the flutter/packages instead?