csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
441 stars 96 forks source link

Update async-data.mdx #370

Closed farkerhaiku closed 2 years ago

farkerhaiku commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Link to main rather than master (master is behind by a few dozen commits). Speaking of which, you might consider changing the github template checklist to refer to main rather than master.

:arrow_heading_down: What is the current behavior?

a link to an outdated branch

:new: What is the new behavior (if this is a feature change)?

a link to the current branch

:boom: Does this PR introduce a breaking change?

nope

:bug: Recommendations for testing

click the link in the docs

:memo: Links to relevant issues/docs

https://gorouter.dev/async-data

:thinking: Checklist before submitting

farkerhaiku commented 2 years ago

I'm not sure that it's necessary to do all of the other things in this checklist, since this is just a documentation update. If you would like me to jump through all those hoops I'll be happy to.

csells commented 2 years ago

good catch!