Chore/improve coverage - Githubissues

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.

https://gorouter.dev

441 stars 97 forks source link

Chore/improve coverage #381

Open Ascenio opened 2 years ago

Ascenio commented 2 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR adds new tests, reaching code paths not previously covered as pointed by a coverage report.

:arrow_heading_down: What is the current behavior?

All tests are currently passing and result in 64.8% coverage.

:new: What is the new behavior (if this is a feature change)?

All tests are currently passing and result in 92.9% coverage.

:boom: Does this PR introduce a breaking change?

No. It does not change any lib/ file.

:bug: Recommendations for testing

If you want to see the coverage report I mentioned before you could use genhtml tool. Just run the following:

flutter test --coverage && genhtml coverage/lcov.info -o coverage/report && open coverage/report/index.html

:memo: Links to relevant issues/docs

None.

:thinking: Checklist before submitting

[X] I made sure all projects build.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I updated the relevant documentation.
[X] I updated the relevant code example.
[X] I rebased onto current master.

chunhtai commented 2 years ago

Since this package has been moved to https://github.com/flutter/packages/tree/main/packages/go_router

Can you create a pull request against the flutter/packages instead?