search

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
441 stars 97 forks source link

Constructor comes first #55

Closed Abhishek01039 closed 3 years ago

Abhishek01039 commented 3 years ago

DO sort constructor declarations before other members.

https://dart-lang.github.io/linter/lints/sort_constructors_first.html

Abhishek01039 commented 3 years ago

Hello @csells can you please review this PR? Thanks

csells commented 3 years ago

@Abhishek01039 I appreciate the enthusiasm. Can I ask why it matters if the constructors come first in the implementation or sample code? Users still have the exact some experience either way...

Abhishek01039 commented 3 years ago

My intention is to follow the best practices. @csells

csells commented 3 years ago

Well, @Abhishek01039, if it makes you happy, it makes me happy. : )

Abhishek01039 commented 3 years ago

Thank you @csells