search

csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.
https://gorouter.dev
442 stars 96 forks source link

pub.dev has broken links to the examples! #61

Closed siliconsorcery closed 2 years ago

siliconsorcery commented 2 years ago

Steps:

Observe: 404 Not Found

csells commented 2 years ago

I never tried the docs from there. Every relative link to files is broken in those docs. I'll fix it.

csells commented 2 years ago

should be fixed in v2.0.0. waiting on pub.dev to regenerate the docs so I can test it.

csells commented 2 years ago

yeah. my HTML base url hack didn't work. I've logged the bug for pub.dev: https://github.com/dart-lang/pub-dev/issues/5173. the fix for that will fix this issue.

rydmike commented 2 years ago

Meanwhile, make links to the examples on GitHub instead, that's what everybody else does... well at least I try to... (😄)

But yeah, it would be nice if they linked to the example code included in the same pub.dev version upload, so great if it can be fixed in pub.dev too.

csells commented 2 years ago

It's not just the examples, it's any file including the images. Too annoying!

rydmike commented 2 years ago

Yes I know. I do the images as raw links to GH instead. I checked how others like, Remi etc were doing images in their package readme files, since I noticed issues with them too.

Another small issue with pub is that the readme file is limited to 128kB, I hit it. There is no warning or info anywhere about the limit, a dry run does not warn about it either, it just fails when there is 1 char over 128kB chars in the readme when you try to publish. At least it then tells you why. Still 256kB would be nice. 🙂

csells commented 2 years ago

fixed with v2.1.2. @siliconsorcery can you please verify?