csells / go_router

The purpose of the go_router for Flutter is to use declarative routes to reduce complexity, regardless of the platform you're targeting (mobile, web, desktop), handling deep linking from Android, iOS and the web while still allowing an easy-to-use developer experience.

https://gorouter.dev

441 stars 97 forks source link

feat: added navigatorBuilder parameter to GoRouter #90

Closed andyduke closed 3 years ago

andyduke commented 3 years ago

This parameter is for inserting widgets above the Navigator, for example, to implement an authentication screen with inner navigation. An example of use in the file "example/lib/auth.dart".

codecov-commenter commented 3 years ago

Codecov Report

Merging #90 (e4a8610) into master (650203c) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files           3        3           
  Lines         383      383           
=======================================
  Hits          259      259           
  Misses        124      124

Impacted Files	Coverage Δ
lib/go_router.dart	`45.09% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 650203c...e4a8610. Read the comment docs.

csells commented 3 years ago

Hey, @andyduke. I really like this! I'm sorry I didn't see it when you first suggested it. Can you update the PR with the following:

rebase on v2.1.2
update the name of the sample to be something like "Navigator Builder" in nav_builder.dart instead of "Authentication" in auth.dart? the sample is really showing off an advanced use of building around the navigator and not authentication; rather authentication is just one thing you can do by injecting into the navigation build process (which is cool as hell, btw!)
update the README with a Navigator Builder sub-section of Nested Navigation

Thanks for the contribution.

andyduke commented 3 years ago

@csells I rebased to 2.1.2, renamed the navigatorBuilder example, and added its description to the README (in a separate section, since this applies not only to nested navigation). After accepting this PR, I would like to make another one with improvements for restorable.