Open ronentk opened 7 months ago
You can see an example output of the script here: https://github.com/csensemakers/desci-sense/blob/main/nlp/desci_sense/shared_functions/schema/ontology.json
Wrote you on discord
On Wed, Feb 14, 2024 at 1:09 AM Ronen Tamari @.***> wrote:
You can see an example output of the script here:
— Reply to this email directly, view it on GitHub https://github.com/csensemakers/desci-sense/issues/110#issuecomment-1942883555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZAPNH4OTLSKSFUQEUYAGDYTP6D7AVCNFSM6AAAAABDHL5SD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSHA4DGNJVGU . You are receiving this because you were mentioned.Message ID: @.***>
@pepoospina I worked on updating the script, now it creates both the json and python versions like we discussed, you can see them here: https://github.com/csensemakers/desci-sense/tree/main/nlp/tests/etc/test_ontology
The data model for creating the ontology is here https://github.com/csensemakers/desci-sense/blob/6d230ac9b7e834dd7f981a3b9aae12fa99d5a8ee/nlp/desci_sense/shared_functions/schema/ontology_base.py#L67
If this looks ok, I will fix the ontology loading to work with the new format (it will override the current format)
And then we can merge our branches - let's talk about it tomorrow :) We should probably also move the data model definitions to the shared location you created for the interface.
@pepoospina
I'm working on a script to convert the Notion ontology to some agreed upon json format. Currently I noticed we're loading it directly from here: https://github.com/csensemakers/desci-sense/blob/main/nlp/desci_sense/shared_functions/schema/ontology.py
Does it make more sense to load it as a json and then it can be language agnostic?
Either way could work I guess, since if I understand correctly I will be providing you API access to the ontology through a function in the python server at https://github.com/csensemakers/desci-sense/blob/main/app/firebase-py/functions/main.py ?
Another question is which format to use to represent the ontology? We can talk about it tomorrow maybe - continuation of the interface discussion from today.