update deps, tweaked config, added yarn pkg, and setup distribution w/ docs - 091817

csepulv / electron-with-create-react-app

Sample Electron application using create-react-app

MIT License

831 stars 217 forks source link

update deps, tweaked config, added yarn pkg, and setup distribution w/ docs - 091817 #10

Closed p3nGu1nZz closed 7 years ago

p3nGu1nZz commented 7 years ago

updated React dependencies
add support to use foreman to run project
merged PR to use npm start not 'npm run dev'
added .env configuration file
suppress browser when starting; only run in electron
moved port from package.json to .env
add support to use yarn package manager
added electron-builder for package distribution
updated documentation on how create from ground up

csepulv commented 7 years ago

I appreciate your interest in the project. I'll go through the PR in a few days, but as a few initial notes:

updating to latest React, Electron makes complete sense
there was already a request for npm start instead of npm run dev. You can take a look at this PR, which was merged into a branch. (also referenced on project README)

It seems you are actively making changes and adding them to the PR. Can you explain your goals a bit?

p3nGu1nZz commented 7 years ago

I am working getting your fantastic code packaging and distributing with electron-builder.. which is turning into not a small feat. I also have been trying to update and put in more detailed step by step process for this, based on your article.

--i updated the request info to reflect my proposed changes

csepulv commented 7 years ago

I suggest you look at this issue. Another user did this, in their own fork. The details are in the referenced issue.

p3nGu1nZz commented 7 years ago

Thanx for the link i will try to recreate and build using that repo and compare.. i was also able to get a nice build working from this repo . Its similiar but is missing some things that i think this repo is doing better; IE naming conventions and config.

p3nGu1nZz commented 7 years ago

also check out this repo which uses auto update. It works the same as this project, however i was able to greatly simplify it. Thanx!

csepulv commented 6 years ago

as a note, I updated to latest react and electron