search

csernazs / pytest-httpserver

Http server for pytest to test http clients
MIT License
214 stars 28 forks source link

HTTPServerBase: change Request to be more verbose respond_nohandler #276

Closed dublet closed 6 months ago

dublet commented 7 months ago

When a Request is not handled and thus triggers the nohandler, it can be very useful to have a more verbose output to indicate which Request is unhandled.

This is particularly useful when you are in a test cycle and trying to determine which requests is mismatching.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f2ee166) 95.50% compared to head (e09fbed) 95.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #276 +/- ## ======================================= Coverage 95.50% 95.50% ======================================= Files 4 4 Lines 601 601 ======================================= Hits 574 574 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

csernazs commented 6 months ago

Thanks! LGTM!

csernazs commented 6 months ago

@dublet is it ok for you to have this released next week? I have released a version recently and I want to wait a bit.

dublet commented 6 months ago

@dublet is it ok for you to have this released next week? I have released a version recently and I want to wait a bit.

Yes, fine by me :+1:

csernazs commented 6 months ago

@dublet pytest 1.0.10 has been released to pypi with your commit, thanks again!

For some reason the search on pypi is outdated for a few days but if you look at https://pypi.org/project/pytest_httpserver/ it will show the latest release as 1.0.10.