csete / gpredict

Gpredict satellite tracking application
http://gpredict.oz9aec.net/
GNU General Public License v2.0
859 stars 251 forks source link

Module configuration files aren't always saved on program exit #196

Closed srcejon closed 4 years ago

srcejon commented 4 years ago

I've noticed sometimes that the module configuration files aren't always updated when exiting the program (specifically the SHOWTRACKS keys). This seems to happen if you have several modules open (but only sometimes, not always).

It looks like this may be related to gtk_sat_map_destroy() being used to save the values for this key. I've noticed that gtk_sat_map_destroy() can be called several times per module or not all.

The gtk docs for widget destroy https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget-destroy say "This signal is not suitable for saving widget state." - so I suspect there may be no guarantee that it is called, and thus the state isn't always saved.