search

csete / gpredict

Gpredict satellite tracking application
http://gpredict.oz9aec.net/
GNU General Public License v2.0
844 stars 247 forks source link

support goocanvas 3 #246

Closed chenrui333 closed 3 years ago

chenrui333 commented 3 years ago

👋 it looks like current gpredict 2.2.1 only supports goocanvas 2

configure: error: Gpredict requires libgoocanvas-2.0-dev

relates to https://github.com/Homebrew/homebrew-core/pull/69285

csete commented 3 years ago

As far as I can see, goocanvas3 has just been released a week ago, so yeah...

I will take a look and see whether it is just a version change or whether there is API/ABI breakage that requires changes in the code. If it is just a version change, we can probably easily support both version 2 and 3. However, in if breaks API or ABI, you should probably prepare to ship both version 2 and 3 and give applications time to migrate properly.

chenrui333 commented 3 years ago

Sounds good. Thanks @csete!

csete commented 3 years ago

@chenrui333 As far as I could see from you patch (PR #251), Gpredict could build against GooCanvas 3 without changes to the code. So I have updated the configure.ac to check for GooCanvas 3 if GooCanvas 2 is not available. Could you please check the current HEAD and see if it works like this? Thanks.

LongnoseRob commented 3 years ago

Just a short feedback, I can confirm this fix on HEAD works, atleast on archlinumx-arm with goocanvas 3.0.0-1. No issue with compiling with this version of goocanvas

csete commented 3 years ago

Thanks, @LongnoseRob!