csete / gpredict

Gpredict satellite tracking application
http://gpredict.oz9aec.net/
GNU General Public License v2.0
833 stars 247 forks source link

Add internationalization to gtk-freq-knob decimal separator #272

Closed nsdecicco closed 6 months ago

nsdecicco commented 2 years ago

Previously, the thousands place separator for gtk-freq-knob was hard-coded as the decimal point (".").

Make the following changes:

Translations are made according to the Wikipedia article on decimal point separators.

Comma Decimal point
UK English Czech
US English Danish
Thai German
Greek
Spanish
Finnish
French
Indonesian
Italian
Lithuanian
Russian
Ukrainian

To keep the commit from being overly large, even though the actual delta of the .po files was quite large (as these have not been updated in 3 years), I added to the commit only the POT generation time change and the addition of the "numeric thousands separator" translations.

davidfdzp commented 2 years ago

Please, consider that Spain is trying to converge with Mexico in the use of dot to separate decimals, even though there is a lot of inertia to use the comma.

nsdecicco commented 2 years ago

Hi @davidfdzp,

I opened a corresponding issue (#273) for this pull request, in which user @wkitty42 pointed out that an alternate (and better) mechanism exists for determining the correct thousands separator to use in the form of the lconv struct.

So, I went ahead and force-pushed a new commit (cca19a18) which uses this new mechanism.

Please let me know what you think.

Thanks,

Nick

csete commented 6 months ago

Thanks for the update @nsdecicco. I have merged the patch.

nsdecicco commented 6 months ago

@csete Thanks for getting this merged!