search

csev / cc4e

C Programming for Everybody
https://www.cc4e.com/
Other
262 stars 90 forks source link

Update chap00.md, chap01.md #31

Closed SarveshMD closed 2 years ago

SarveshMD commented 2 years ago

Also updated chap06.md a bit. Completed fixing formatting errors in chap00.md, and half way through chap01.md.

SarveshMD commented 2 years ago

I wanted to leave a question to Dr. Chuck. In many places of the markdown version of the book, the references to the programming language PL/I is bolded in the markdown files, but I don't think they are bolded in the scanned book. I wanted to ask you if I can change the bolded PL/I to non-bolded in the markdown version of the book, or shall I leave those bolded PL/I alone ?

csev commented 2 years ago

Lets take out the bold for PL/I - I agree that while the OCR seemed to detect bold - the original book does not bold these. You know that you did not have to take back your pull request and resubmit. If you kept pushing to your branch the PR just updates. Thanks for restoring the first hello world. Let me know if the README.md needs improvement - I put it together quickly last night.

SarveshMD commented 2 years ago

@csev Thanks. I am very new to working with GitHub repositories, so I didn't know that I could just add another commit to the previous #30 Pull request. I don't think README.md needs any improvement. Thanks a lot for the README.md. Some other things I wanted to ask you was, in book/code/c_026_01.c, a function is called get_line, but in the book, it is getline without the underscore in between. Should I change the name to getline or shall I leave it alone ?, and in chap01.md, I found two random Yada lines, are they added for some reminder or shall I remove those ?

Yada:

Screenshot from 2021-07-22 12-48-47

csev commented 2 years ago

If you ever find a "Yada" - it was something that I was debugging - but forgot to remove. Please remove them whenever you find them.

The get_line is changed to avoid conflict with stdio.h - it (so far) is the only place I had to deviate from the sample code in the book.