search

csexton / captured-mac

Captured
http://www.capturedapp.com
MIT License
5 stars 1 forks source link

Remove Dropbox Support #35

Closed csexton closed 8 years ago

csexton commented 8 years ago

There were a few reasons to drop support.

  1. They built this feature into their client.
  2. Their SDK only supported on global account. But the structure of Captured is intended to allow multiple accounts associated with one or more shortcuts.
  3. I don't personally want to use DB support, so unless @jorgev wants to build and maintain it didn't seem compelling roll my own code to work with their REST API directly.

image

jorgev commented 8 years ago

I might still take a stab at this...can we just remove it from the UI and I'll continue to work on it? I have used their SDK before, so if we go this route maybe we can support the multiple accounts. Also, just for completeness sake, seems like might be a good thing to keep in. Furthermore, as we discussed this week, people might want to disable the native feature in Dropbox (maybe they don't want ALL their screenshots uploaded) but still want Captured screenshots uploaded.

Thoughts?

csexton commented 8 years ago

@jorgev certainly, happy to have it--just wanted to yank it for now to get the release out.

I removed it in a single commit so we have a record of all the changes. It was working, but in a weird cobbled together way. I think if we used their REST API directly we wouldn't have nearly so many compromises in the code base. Just a little more work on our side.