Do not expose FlexDi types from the public API

csf-dev / CSF.Screenplay

Implementation of the Screenplay pattern (aka Journey) in .NET

https://csf-dev.github.io/CSF.Screenplay/

MIT License

13 stars 1 forks source link

Do not expose FlexDi types from the public API #113

Closed craigfowler closed 6 years ago

craigfowler commented 6 years ago

Currently a few of FlexDi's types are exposed from Screenplay. This shouldn't happen and they should be abstracted via a facade layer.

The reason for this is so that consuming projects don't need to take a dependency upon FlexDi in order to use Screenplay.

This is definitely the registration helper but maybe other things too.

craigfowler commented 6 years ago

I'm going to close this as a won't fix. Actually, forcing a dependency upon FlexDi is not so bad after all, but it will be important that any breaking change to FlexDi will become a breaking change to Screenplay (because of the relationship in their public APIs. Thus any time FlexDi publishes a major version increment, Screenplay will have to do the same (or not take the upgrade).