csfloat / extension

Source Code that Powers the CSFloat Extensions
https://csfloat.com
MIT License
83 stars 15 forks source link

Support Extension on Firefox #243

Open u254254 opened 1 week ago

u254254 commented 1 week ago

Popup "Setup Trade Verification" says this:

At the moment, you need to use a Chromium browser (ie. Chrome, Opera GX) in order to use the CSFloat extension. In the future, Firefox will support it -- sorry!

Version 4.3.1 for Firefox is already on GitHub Releases, meaning it technically supports Firefox. Why not just submit new version to Mozilla and make it available in Firefox?

Fesiug commented 1 week ago

Agreed, having to install and use a Chromium browser side-by-side with my normal one to verify trades is annoying. What's keeping the newest version extension from being updated and pushed to Firefox Addons?

Step7750 commented 1 week ago

Current blocker for the Firefox extension is mainly related to permission handling. In FF land, permissions specified by the manifest are still treated somewhat "optional" by the browser -- which completely breaks functionality (ie. annoying support tickets on our end when users fiddle around).

The current dialog that grants permissions requires a trusted event to propagate to the service worker in order to request permissions. In Chrome, it properly handles scoping the closure with "trust", but Firefox has a long-standing issue where this is not the case. It'd require reworking where/how to grant permissions since requesting the user to manually grant it by going to the extension's settings is very error prone.

Given these issues, we've focused on other platforms such as mobile for the time being.

Step7750 commented 1 week ago

Version 4.3.1 for Firefox is already on GitHub Releases, meaning it technically supports Firefox. Why not just submit new version to Mozilla and make it available in Firefox?

These versions are automatically built by a bot, Firefox doesn't support trade offer tracking due to the reasons mentioned above.