csfloat / inspect

Source Code that Powers the CSFloat Inspect Link API
https://csgofloat.com
MIT License
403 stars 119 forks source link

Sticker wear #108

Closed sFireFrog closed 1 year ago

sFireFrog commented 2 years ago

Sticker wear is now always 0.Did steam change something?

Step7750 commented 2 years ago

Please give an example of an item that has obvious sticker wear in-game but shows up at 0.00 in the API.

Specifically, include the inspect link.

MaxsonClackson commented 1 year ago

Please give an example of an item that has obvious sticker wear in-game but shows up at 0.00 in the API.

Specifically, include the inspect link.

@Step7750 Hello. Actully, there is a problem with the wear of stickers. I bought 2 items that show 100% wear. After I saw on the Buff that they have a wear of 0. I looked in cs and indeed the stickers were completely erased or there were scuffs. Examples:

steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20S76561199255329491A28540289078D14044174911626201433

steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M4242989842920296363A28597345604D10260471416862409595

There were also lots with incorrect wear. But this is on the market. Of course I can't find them.

Step7750 commented 1 year ago

This is because we have very aggressive caching (kind of necessary for the prod API since we get 100 million+ requests per day). If we want to have sufficient speed (Valve's GC is slower than our internal caches) for the majority of requests, this is necessary.

So, this is a known tradeoff between performance and freshness -- notably Valve is kind enough to not change the inspect URL at all when a sticker is scratched.

Once a sticker is fully scratched, the URL changes and will cache bust on our end.

wangxingzhen commented 7 months ago

This is because we have very aggressive caching (kind of necessary for the prod API since we get 100 million+ requests per day). If we want to have sufficient speed (Valve's GC is slower than our internal caches) for the majority of requests, this is necessary.

So, this is a known tradeoff between performance and freshness -- notably Valve is kind enough to not change the inspect URL at all when a sticker is scratched.

Once a sticker is fully scratched, the URL changes and will cache bust on our end.

Whether it is possible to add a flag parameter that indicates whether to use caching by default or to call Valve directly

wangxingzhen commented 7 months ago

This is because we have very aggressive caching (kind of necessary for the prod API since we get 100 million+ requests per day). If we want to have sufficient speed (Valve's GC is slower than our internal caches) for the majority of requests, this is necessary. So, this is a known tradeoff between performance and freshness -- notably Valve is kind enough to not change the inspect URL at all when a sticker is scratched. Once a sticker is fully scratched, the URL changes and will cache bust on our end.

Whether it is possible to add a flag parameter that indicates whether to use caching by default or to call Valve directly

Or, if it has a sticker, don't cache it and just call Valve every time