get_ram function for Windows 10 (#41)

csgillespie / benchmarkme

Crowd sourced benchmarking

https://csgillespie.github.io/benchmarkme/

40 stars 13 forks source link

get_ram function for Windows 10 (#41) #42

Closed csgillespie closed 2 years ago

csgillespie commented 2 years ago

added na.rm=T in line 44
Replaced || with &&.
Interchanged metric and iec.
prioritized iec over metric; reverted to original metric and iec values; changed iec and metric vectors.
Corrected my wrong interchange of iec and metric values

csgillespie commented 2 years ago

@ArkaB-DS I've made a few tweaks based on your suggestions. Removing solaris makes the logic a bit easier - we can just remove all white space and empty strings on the first step.

Can you check?

I'll think about the metric bit now - I hate bits vs bytes

ArkaB-DS commented 2 years ago

@ArkaB-DS I've made a few tweaks based on your suggestions. Removing solaris makes the logic a bit easier - we can just remove all white space and empty strings on the first step.

Can you check?

I'll think about the metric bit now - I hate bits vs bytes

After doing "clean and rebuild" on the changes made in the dev branch, I got the desired results -

> library(benchmarkme)
> get_ram()
8 GiB

Thank you.