search

csgillespie / benchmarkme

Crowd sourced benchmarking
https://csgillespie.github.io/benchmarkme/
40 stars 13 forks source link

get_ram() returns NA B on Windows 10/11 Pro machines #44

Closed xiaodaigh closed 2 years ago

xiaodaigh commented 2 years ago

get_ram() returns NA B but benchmarkme:::get_windows_ram() gives "17179869184 \r" "17179869184 \r" "17179869184 \r" "17179869184 \r" "\r"

sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 22000)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252   
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C                          
[5] LC_TIME=English_United States.1252    
system code page: 65001
csgillespie commented 2 years ago

I updated the GitHub version about a week ago. Does that work for you? If so, I'll update the CRAN version

xiaodaigh commented 2 years ago

Nope. Still get NA B

csgillespie commented 2 years ago

Any chance you could try https://github.com/csgillespie/benchmarkme/blob/main/R/get_ram.R#L1 and see if there's a fix?

I don't use Windows

xiaodaigh commented 2 years ago

issue seems to be https://github.com/csgillespie/benchmarkme/blob/6a342e41dde9eb8a7c077ad343be299f0afdca17/R/clean_ram_output.R#L15

Wonder why it filters out length(ram) > 1? I will make a PR

mroddc commented 2 years ago

I keep getting this issue too. I'm on Windows 10, R 4.2.0 This was also happening on 4.1 versions. It causes an issue with the disk.frame package, which depends on get_ram(). As a result, disk.frame is inefficient because it defaults to 16gb

Has there been any update?

get_ram() Unable to detect your RAM. # nocov Please raise an issue at https://github.com/csgillespie/benchmarkme

mroddc commented 2 years ago

awesome. I can confirm that it is working on my R environment, RStudio, Windows 10. Thanks!

On Wed, Jun 15, 2022 at 4:55 AM Colin Gillespie @.***> wrote:

Closed #44 https://github.com/csgillespie/benchmarkme/issues/44 as completed via #47 https://github.com/csgillespie/benchmarkme/pull/47.

— Reply to this email directly, view it on GitHub https://github.com/csgillespie/benchmarkme/issues/44#event-6811006435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYZJY6DOOXESU6FWTDO333VPGLBHANCNFSM5NE6G46A . You are receiving this because you commented.Message ID: @.***>