search

csgillespie / efficientR

Efficient R programming: a book
https://csgillespie.github.io/efficientR/
Other
719 stars 375 forks source link

Suspected typo in Chapter 1 #302

Open michaelosheaa opened 3 years ago

michaelosheaa commented 3 years ago

I noticed in Line 76 of Chapter 1 the sentence: "It is well known that R code can promote algorithmic efficiency compared with low level languages for certain tasks, especially if the code was written by someone who doesn't fully understand the language."

Robinlovelace commented 3 years ago

Hi @michaelosheaa yes I think that is a typo! Fix would be most welcome, thanks for pointing this out.

shafayetShafee commented 2 years ago

@Robinlovelace , can I make a pull request to fix this typo 😄?

Robinlovelace commented 2 years ago

Hi @shafayetShafee yes of course, that would be most welcome. Many thanks!

shafayetShafee commented 2 years ago

@Robinlovelace, hey I am noticing that this typo still exists in the online version of the book, although I have corrected it and PR got merged. Did I miss something? Sorry if I did something wrong 😓!

Robinlovelace commented 2 years ago

No that is probably an issue with the build process. Can you help @csgillespie ?

csgillespie commented 2 years ago

This is going to be tricky. It was originally set up via .travis many, many years ago. Converting to GitHub Actions is going to take a little time.