Add re-vote maps on tie

[cameronshinn]

I'm assuming you have all the map_pool function arguments added in because I said that we don't want to modify self.map_pool to keep it the same as the guild's value in the database.

Assuming that is the case I think it would just be easier to modify self.map_pool and take out the function arguments. However, if there is any other reason we need to preserve the original map pool then we could make a new attribute to store the map pool as it decreases. Could call it self.runoff_map_pool perhaps?

[thboss]

@cameronshinn I didn't understand the problem of that, modifying self.map_pool in MapVoteMenu class doesn't change the map pool in the database!

[cameronshinn]

Yes it doesn't. There isn't any problem if you want to modify self.map_pool. I'd prefer that than have to add an argument to every single function.

[cameronshinn]

@thboss can you move the volunteer pick improvements to another PR? Also are you going to remove the map_pool arguments that you added? You can just use self.map_pool instead of adding an argument to every method.

[B3none]

It makes sense to have these changes separate @thboss - would be good to see this stuff merged :)

[thboss]

I can't open multiple PRs

[B3none]

@thboss you can