search

csgo-league / csgo-league-bot

League Discord bot
https://discord.gg/b5MhANU
GNU General Public License v3.0
14 stars 12 forks source link

q!stats @mention to check other stats #41

Closed 39ma closed 4 years ago

cameronshinn commented 4 years ago

I remembered why I didn't implement this in the first place: Because people wouldn't want to be pinged over someone looking at their stats. I figured it made sense for bans, unbans and queue pops, but not this.

@b3none what are your thoughts on this?

AllowedMentions in the discord.py documentation gives a way to send mentions in messages without pinging them, but I don't think there is any way to implement this when users are sending the message.

cameronshinn commented 4 years ago

@39ma the linter is still giving errors for the whitespace on lines 40 and 45.

39ma commented 4 years ago

I remembered why I didn't implement this in the first place: Because people wouldn't want to be pinged over someone looking at their stats. I figured it made sense for bans, unbans and queue pops, but not this.

@b3none what are your thoughts on this?

AllowedMentions in the discord.py documentation gives a way to send mentions in messages without pinging them, but I don't think there is any way to implement this when users are sending the message.

may be make a function that bot will delete user's message immediately and show his stats.

B3none commented 4 years ago

Is there any way that a user can mute direct notifications from a specific channel?

cameronshinn commented 4 years ago

may be make a function that bot will delete user's message immediately and show his stats.

@39ma I think that would still leave the notification and then they wouldn't see anything when they went to channel. Might be more annoying if they don't know what it was from.

@b3none you can mute mentions in a specific channel. Since the common use case for the bot is to use it in a single channel, they would end up missing other notifications however. The server owner/users would have to mute it manually unless we automate the channels the bot uses (then we'd know what channel to mute). I'd rather leave this PR as is then add that complexity just for this small feature.

cameronshinn commented 4 years ago

The next best option would be to use user names or IDs but the autocomplete of mentions is very nice.

cameronshinn commented 4 years ago

@39ma I'll add this in if you get rid of the linting errors first.