/players /matches redirects itself forever when system has no users

csgo-league / csgo-league-web

League web panel

https://discord.gg/b5MhANU

GNU General Public License v3.0

44 stars 12 forks source link

/players /matches redirects itself forever when system has no users #8

Closed FlowingSPDG closed 5 years ago

FlowingSPDG commented 5 years ago

Describe /players /matches redirects itself forever when system has no users (or matches).

Expected behavior shows "not found" error

Screenshots

OS: WSL Ubuntu
Browser Google Chrome
Version PHP7.2

Additional context How do I register user btw?

B3none commented 5 years ago

You can log in with steam, to actually get players in the system it will need some rankme data. I'll look into fixing this redirect error now.

FlowingSPDG commented 5 years ago

I found PHP error when I log in with Steam,probably Content-Type issue? https://github.com/csgo-league/csgo-league-web/blob/77f4d591591325071550b49bc31ec819b507bff0/src/Helpers/SteamHelper.php#L132

B3none commented 5 years ago

That's a notice but it should still work, I'll have to look a little further into this and let you know. Just updating the game code atm.

FlowingSPDG commented 5 years ago

Alright,thanks! I have to sleep from now. Again this project is awesome,if you need test ppl/env,please let me know and I'll help it for sure!

B3none commented 5 years ago

Alright,thanks! I have to sleep from now. Again this project is awesome,if you need test ppl/env,please let me know and I'll help it for sure!

Would be neat to get this running through some test players, it's still got a few rough edges. The main thing I need to test is the CS:GO statistics because it's a butchered version of Kento's RankMe