search

csharpfritz / InstantAPIs

A library that generates Minimal API endpoints for an Entity Framework context.
MIT License
448 stars 58 forks source link

Remove 'Fritz' from the project, namespace, and NuGet package names #41

Open csharpfritz opened 2 years ago

csharpfritz commented 2 years ago
ChristianWeyer commented 2 years ago

Nice little project, @csharpfritz :-)

Do you also consider renaming it to more reflect the fact that it is not about APIs per se - but more like data-driven (or CRUD?) APIs? The DB-/DbContext-centric approach implies a certain kind of use case and usage patterns when it comes to APIs - and thus should püorbably be reflected in the lib name.

csharpfritz commented 2 years ago

With the introduction of the JSON APIs in this preview version I published today, there are now more ways to create APIs to expose data.

I think the name "InstantAPIs" reflects what a developer wants to create: Web APIs with 1 or 2 lines of code.

ChristianWeyer commented 2 years ago

Thanks for your thoughts, Jeff.

csharpfritz commented 2 years ago

I appreciate the discussion and different point of view.

csharpfritz commented 2 years ago

I think I'll go through this rename today on stream

ScottKane commented 2 years ago

Created PR #62 for this

davidbuckleyni commented 2 years ago

I like the name RapidAdaptiveApi meaning that while its instant also custom.

davidbuckleyni commented 2 years ago

Created PR #62 for this @ScottKane as fritz said on stream reach out first and dicuss with him u missed a comment he was going to do the rename as part of the stream. As fritz said its good etiquette to ask them first.

ScottKane commented 2 years ago

@davidbuckleyni that doesn't really fit with how git works, accept the PR or don't. I did exactly what was described in the issue. Also if you notice there is a comment from 25 days ago saying the same thing about doing it on stream, yet it was still up for grabs today...

ScottKane commented 2 years ago

Also I think you should drop the s from InstantAPIs and rename to InstantApi (gotta be pascal even though acronyms feel wrong)

davidbuckleyni commented 2 years ago

I am just going by what firtz said in his stream yesterday @ScottKane i think he will need to raise it again

ScottKane commented 2 years ago

I watched the stream. What he said about etiquette was in regards to people creating PR's that touch way more than they should is bad etiquette. This is normal in open source so I am more that happy submitting a PR against an open issue doing exactly what it describes and nothing more.

ScottKane commented 2 years ago

Not to mention renaming is a boring laborious task and I'm sure @csharpfritz would rather cover something more interesting.

csharpfritz commented 2 years ago

Thank you for the work on this patch, yes.. I wasn't able to get to it on stream and I'm glad to see the work to implement the change.

We need one more fix to go into the GitHub worklow to reference the new project names appropriately and then it can be merged... as well as deploy with the new NuGet name

ScottKane commented 2 years ago

Should be good to go now :)

csharpfritz commented 2 years ago

Merged it... now going to rename the NuGet package

rkmiecik commented 2 years ago

@csharpfritz If I use this package now in my projetc, when you change the packages's name, my project will stop working?