search

csharpfritz / TAML

Defining the coolest and simplest markup language delimited ONLY by tabs
MIT License
23 stars 11 forks source link

Add Configuration.Taml.Net #74

Closed Kahbazi closed 3 years ago

Kahbazi commented 3 years ago

Fixes https://github.com/csharpfritz/TAML/issues/63

csharpfritz commented 3 years ago

Thank you so much for putting this together so quickly! I noticed that the folder and project name is not spelled correctly: Configuration.Taml.NET

I'll review more of the code

csharpfritz commented 3 years ago

I don't think we should reference the Taml.NET project directly, but rather go through a NuGet package reference so that consumers get that NuGet package installed as well.

csharpfritz commented 3 years ago

I like the inline TAML in the tests!

Kahbazi commented 3 years ago

but rather go through a NuGet package reference so that consumers get that NuGet package installed as well.

This shouldn't be necessary. By referencing the nuget package Configuration.Taml.Net will always be one package behind. Also dotnet pack would detect that TAML.NET is a package and add that to the dependencies of Configuration.Taml.Net.

csharpfritz commented 3 years ago

I'm going to review and merge this in today's stream. We'll add a GitHub action to publish a NuGet package as well. HUGE thanks for the contribution!