Closed vanillajonathan closed 4 years ago
@davetransom ping!
Sorry @vanillajonathan, I forgot about this one when I didn't quite know how I should reply straight away.
The documentation corrections are worth accepting (and thank you), however, reorganising the struct is not something I'd merge as I've written it the way I want it.
I'll happily merge if you revert the stylistic changes.
But members of a class should be have theit member visibility explicitly declared, and if not explicitly declared as private, they are implicitly internal, and in this case I believe they should be private. Also private and internal members should be placed above public members, and non-static members should be placed above static members according to the Microsoft Framework Design Guidelines.
Are you confusing default access modifiers for class (internal) vs members (private)?
My previous comment still stands.
Yes. I am confusing default access modifiers.
I updated the patch.
Explicitly declare property visibility. Proper capitalization of Base64. Proper punctuation.